New context API by acdlite · Pull Request #11818 · facebook/react · GitHub

  • Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
  • Already on GitHub?
  • Sign in to your account

react – A declarative, efficient, and flexible JavaScript library for building user interfaces.

returns false.

Corresponding RFC: reactjs/rfcs#2

We’ll land this behind a feature flag and try it out on a Facebook product (also behind a feature flag) to get some real-world performance data. My plan is to build the React Redux API on top of it, find our largest product that uses Redux, swap out the implementation, and see what happens.

TODO:

More TODOs:

Do you think it’s worth copy pasting all/most old tests using context and porting them to the new API?

we should ping the enzyme folks as well, they’ll most likely need to update the traversal logic. @aweary

Why does this affect traversal?

sort. I maybe have just been reading the PR wrong  ignore me!

instead (not updated PR yet). But it’s a good point to consider.

internally.

Eventually yeah. Semantically there’s no reason it shouldn’t. The biggest open question is performance, so before we worry about upgrade paths we need to find an implementation that works at scale. So I’d rather land this behind a feature flag and try this out on www.

Fwiw I’d be happy to test this out at Webflow, too, and share any perf data.

Silly GitHub has hidden my comment. Please don’t ignore it. 🙂

Updated with test for reentrant server renders

. It’ll let Flow know what it is but also potentially…

New context API by acdlite · Pull Request #11818 · facebook/react · GitHub